data type for each element to be made optional in the resulting xml #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quandyfactory
added a commit
that referenced
this pull request
Jun 3, 2014
data type for each element to be made optional in the resulting xml, kindly provided courtesy of gauravub
|
Changes look great. Thank you! |
|
Happy to contribute.. Cheers ..!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the current code, each element in the final xml that is generated contains a "type" attribute with the datatype. this pull request is to review the code change that makes it optional.
The code contains a new attribute "attr_type" which is set to True by default, so it will work as the current code does. If it is set to False, then the resulting xml will not contain the type attribute for the elements.